Formal Code Review Process is No Good

Perfunctory is common. There are better alternatives.

Zhimin Zhan

--

With Git’s Pull Request feature, many so-called ‘Agile’ teams introduced a formal code review process. While a “PR review” process might sound good (in theory), it often turned out to have little value for too much effort. In my opinion, not worth it. There are other much simpler and more effective ways, if the main goal is to prevent bad code (mostly in a form of introducing defects and bad design).

Two years ago, I already expressed my opinion after observing many “LGTM” (look good to me, i.e. don’t care) style code reviews.

Think about it, the developers even abbreviated the request for approval (Code Review), will they examine the code carefully? Of course not. My view is not alone, here is a funny picture posted on LinkedIn, with 5951 likes/reactions.

Source: https://www.linkedin.com/feed/update/urn:li:activity:7039897678494740480/

--

--

No responses yet